x86/smpboot: Log error on secondary CPU wakeup failure at ERR level [Linux 3.15]

This Linux kernel change "x86/smpboot: Log error on secondary CPU wakeup failure at ERR level" is included in the Linux 3.15 release. This change is authored by Igor Mammedov <imammedo [at] redhat.com> on Thu Jun 5 15:42:44 2014 +0200. The commit for this change in Linux stable tree is feef1e8 (patch).

x86/smpboot: Log error on secondary CPU wakeup failure at ERR level

If system is running without debug level logging,
it will not log error if do_boot_cpu() failed to
wakeup AP. It may lead to silent AP bringup
failures at boot time.
Change message level to KERN_ERR to make error
visible to user as it's done on other architectures.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Toshi Kani <toshi.kani@hp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1401975765-22328-3-git-send-email-imammedo@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 arch/x86/kernel/smpboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 2988f69..ae2fd975 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -918,7 +918,7 @@ int native_cpu_up(unsigned int cpu, struct task_struct *tidle)

    err = do_boot_cpu(apicid, cpu, tidle);
    if (err) {
-       pr_debug("do_boot_cpu failed %dn", err);
+       pr_err("do_boot_cpu failed(%d) to wakeup CPU#%un", err, cpu);
        return -EIO;
    }

Leave a Reply

Your email address will not be published. Required fields are marked *